Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixManager: Fix behavior for updating node subscriptions #669

Closed
wants to merge 1 commit into from

Conversation

melvo
Copy link
Contributor

@melvo melvo commented Nov 18, 2024

If no nodes were specified to be unsubscribed from for updateSubscriptions(), all enums were added to be unsubscribed from. That resulted in the same nodes being specified to be subcribed to and to be unsubscribed from.

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Update doc/doap.xml
  • Add unit tests
  • Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

If no nodes were specified to be unsubscribed from for
updateSubscriptions(), all enums were added to be unsubscribed from.
That resulted in the same nodes being specified to be subcribed to and
to be unsubscribed from.
@melvo melvo closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant