Clarify and simplify expr data type #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make`parse_all()$expr` a list of expressions, where the length is the number of individual expressions within each top-level expression.
hadley
commented
Jun 16, 2024
| if (debug) message(src) | ||
|
|
||
| if (is.null(call) && !last) { |
There was a problem hiding this comment.
This was a performance optimisation (since we don't really need to set up all the various handlers if there's no code to execute), so removing it will make the code a little slower. However, I plan to set up all the handlers once (instead of once per top-level expression) and this makes it a little bit easier to reason about in the interim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
parse_all()$expra list of expressions, where the length is the number of individual expressions within each top-level expression.