Skip to content

add rlang min requirement and update snapshot #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

add rlang min requirement and update snapshot #236

merged 2 commits into from
Jan 22, 2025

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jan 22, 2025

rlang 1.1.5 has been released recently and it impacts snapshot by fixing the traceback.

This PR add minimum requirement and update the snapshot.

Related to CI error in #235

@hadley
Copy link
Member

hadley commented Jan 22, 2025

@cderv thanks for figuring this out! Looks like there's still a problem on Windows.

@cderv
Copy link
Collaborator Author

cderv commented Jan 22, 2025

I am creating the snapshot on windows though 🤔
I'll look into this, maybe another reproducible output problem. But it is only on R 4.1 so could be difference in R version on windows

@cderv
Copy link
Collaborator Author

cderv commented Jan 22, 2025

Some fancy display difference

diff --git "a/.\\rmd-stop-error-auto-entrace.txt" "b/.\\rmd-stop-error-auto-entrace.new.txt"
index a1867ee..c6c1d52 100644
--- "a/.\\rmd-stop-error-auto-entrace.txt"
+++ "b/.\\rmd-stop-error-auto-entrace.new.txt"
@@ -4,10 +4,10 @@ processing file: ressources/with-stop-error-auto-entrace.Rmd
 Error in `h()`:
 ! !
 Backtrace:
-
- 1. └─global f()
- 2.   └─global g()
- 3.     └─global h()
+    x
+ 1. \-global f()
+ 2.   \-global g()
+ 3.     \-global h()
 
 Quitting from lines 6-10 [unnamed-chunk-1] (ressources/with-stop-error-auto-entrace.Rmd)
 Execution halted

@hadley
Copy link
Member

hadley commented Jan 22, 2025

I think you probably need to set options(cli.unicode = FALSE) in that process. testthat normally does it for you, but I bet the options don't percolate through to that subprocess

...

That's literally just what you did 😄

@hadley hadley merged commit 094f832 into main Jan 22, 2025
14 checks passed
@hadley hadley deleted the update-snapshot branch January 22, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants