Skip to content

Skip NA test on RISCV64, it is non-portable #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Feb 4, 2025

Fixes: #485

Inspired by #485 (comment)

@TimTaylor
Copy link

TimTaylor commented Feb 4, 2025

Disclaimer - I've nothing to do with fs development but, FWIW, my comment assumed you were patching downstream in Debian with the understanding that R generally will be a little broken on riscv.

I'm not sure skipping the test upstream is the right way to go. Personally I'd want to see that failure (the formatting is broken on riscv and this shows that). If upstream did decide to skip it they will probably want to do it by the testthat skip mechanism so it is atleast flagged in their test suite for future consideration.

@gaborcsardi
Copy link
Member

AFAIU this is not specific to Debian, so I am going to skip the test using testthat. Let me know if that's not the right solution.

@gaborcsardi
Copy link
Member

Thank you!

@gaborcsardi gaborcsardi merged commit cec7c6f into r-lib:main Apr 25, 2025
20 checks passed
@mr-c mr-c deleted the riscv64-skip-nonportable-test branch April 25, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

riscv64 test failure: format(fs_bytes(NA)) (actual) not equal to "NA" (expected)
4 participants