lintr >= 3.0.0 support

[AshesITR]

Still missing some documentation.

NB there are quite a few lints on lifecycle code:

Lints in lifecycle code

R/compat-obj-type.R:58:9: style: [lifecycle_linter] `rlang::is_na` is questioning
    if (is_na(x)) {
        ^~~~~
R/deprecate.R:288:16: style: [lifecycle_linter] `rlang::chr` is questioning
    details <- chr()
               ^~~
R/expect.R:34:27: style: [lifecycle_linter] `rlang::is_na` is questioning
  if (!is_null(regexp) && is_na(regexp)) {
                          ^~~~~
R/lifecycle-package.R:16:3: style: [lifecycle_linter] `rlang::local_use_cli` is experimental
  local_use_cli()
  ^~~~~~~~~~~~~
R/utils.R:10:9: style: [lifecycle_linter] `rlang::chr` is questioning
  paste(chr(...), collapse = "\n")
        ^~~
vignettes/manage.Rmd:34:8: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df1 <- data_frame(x = 1, y = 2)
       ^~~~~~~~~~
vignettes/manage.Rmd:37:8: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df2 <- data_frame(a = "apple", b = "banana")
       ^~~~~~~~~~
vignettes/manage.Rmd:62:8: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df1 <- data_frame(x = 1, y = 2)
       ^~~~~~~~~~
vignettes/manage.Rmd:63:8: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df2 <- data_frame(a = "apple", b = "banana")
       ^~~~~~~~~~
vignettes/manage.Rmd:72:8: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df1 <- data_frame(x = 1, y = 2)
       ^~~~~~~~~~
vignettes/stages.Rmd:52:15: style: [lifecycle_linter] `tibble::data_frame` is deprecated
df <- tibble::data_frame(x = 1)
              ^~~~~~~~~~

[AshesITR]

fixes #122, #155, #165, #178, #179

[AshesITR]

I'm not sure if pkg_lifecycle_statuses() is documented in a good place at ?lifecycle_linter.
Also, pattern= might drift from lintr in the future. It might be worth deprecating the argument and not passing it on?

Users of lintr could simply add linters: linters_with_defaults(lifecycle::lifecycle_linter()) to their configs to include it in the regular workflow.

I also opted to default to tidyverse::tidyverse_packages() for the packages= argument of lifecycle_linter().
This makes lifecycle::lifecycle_linter() behave nicely by default, but implicitly requires tidyverse or a non-missing packages= argument. I could add a check for robustness there if you agree with this behavior.

[AshesITR]

NB this is for PyCharm

[AshesITR]

This makes linters_with_tags("best_practices", packages = "lifecycle") work.

[AshesITR]

Idea for future expansion: except = character() arg to explicitly allow some functions.

[AshesITR]

cc @hadley LMK if you need anything. I didn't write any tests because there were none before and adding them would require a significant amount of work.

[Moohan]

I just installed this version and got this message (red font)

Registered S3 methods overwritten by 'callr':
  method                    from
  format.callr_status_error     
  print.callr_status_error   

Other than that, it works as expected for lifecycle::lint_lifecycle(packages = packages) whereas v1.0.4 does not.

[hadley]

Thanks!