-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lintr >= 3.0.0 support #180
base: main
Are you sure you want to change the base?
Conversation
I'm not sure if Users of lintr could simply add I also opted to default to |
@@ -7,6 +7,7 @@ | |||
^pkgdown$ | |||
^lifecycle\.Rproj$ | |||
^\.Rproj\.user$ | |||
^\.idea$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB this is for PyCharm
@@ -0,0 +1,2 @@ | |||
linter,tags | |||
lifecycle_linter,robustness best_practices configurable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes linters_with_tags("best_practices", packages = "lifecycle")
work.
packages = tidyverse::tidyverse_packages(), | ||
which = c("superseded", "deprecated", "questioning", "defunct", "experimental", "soft-deprecated", "retired"), | ||
symbol_is_undesirable = FALSE | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea for future expansion: except = character()
arg to explicitly allow some functions.
cc @hadley LMK if you need anything. I didn't write any tests because there were none before and adding them would require a significant amount of work. |
Still missing some documentation.
NB there are quite a few lints on
lifecycle
code: