Enforce the native pipe by default #2796
Merged
+125
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 127 127
Lines 6988 6989 +1
=======================================
+ Hits 6963 6964 +1
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AshesITR
reviewed
Feb 27, 2025
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
MichaelChirico
commented
Feb 27, 2025
AshesITR
reviewed
Mar 1, 2025
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
AshesITR
previously approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the NEWS.md documentation to reflect the enforced use of R’s native pipe (|>) by default, aligning with the updated Tidyverse Style Guide. Key changes include:
- Updated description for pipe_consistency_linter() to indicate the new default.
- Addition of a new section for changes to default linters.
Files not reviewed (8)
- R/pipe_consistency_linter.R: Language not supported
- R/zzz.R: Language not supported
- inst/lintr/linters.csv: Language not supported
- man/default_linters.Rd: Language not supported
- man/linters.Rd: Language not supported
- man/pipe_consistency_linter.Rd: Language not supported
- tests/testthat/default_linter_testcode.R: Language not supported
- tests/testthat/test-pipe_consistency_linter.R: Language not supported
LOL |
|
bad bot copilot 😂 |
This comment was marked as outdated.
This comment was marked as outdated.
|
Again, this was reviewed, staled only by merge conflicts. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2707. Progress on #2737.
About cautions for switching from
%>%to|>, my first instinct is we should leave that to the style guide, any thoughts?