Skip to content

lint(text=) finds local settings again #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Jun 21, 2025

Closes #2847, cc @bastistician

Not the biggest fan of the new parse_settings=FALSE usages, open to ideas about what needs to be improved here...

PS, I originally pushed this directly to main by mistake as b548c78; reverted as dc7a612 to put this through normal review

Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (dc7a612) to head (07d31f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2863   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         127      127           
  Lines        7068     7068           
=======================================
  Hits         7043     7043           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico
Copy link
Collaborator Author

Hm, I think this is having an interaction with the lack of {cyclocomp}. IINM package examples of lint(text=.) are trying to use our ./.lintr config, which requires having {cyclocomp}. Testing if 159234d works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lintr::lint(text=) no longer reads personal settings
1 participant