Skip to content

move sudo to outside execute of system_requirements_internal #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lz100 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

move sudo to outside execute of system_requirements_internal #279

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
065ca0a
move sudo outside
lz100 Mar 2, 2021
27eac9a
fix length 0 problem
lz100 Mar 2, 2021
23961e8
accept suggestion
lz100 Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions R/system-requirements.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@ system_requirements_internal <- function(os, os_release, root, package, execute,
callback <- function(x, ...) invisible()
}

if (all(sudo, length(commands))) {
commands <- paste("sudo", commands)
}

if (execute) {
for (cmd in commands) {
if (sudo) {
cmd <- paste("sudo", cmd)
}
cli::cli_alert_info("Executing {.code {cmd}}")

processx::run("sh", c("-c", cmd), stdout_callback = callback, stderr_to_stdout = TRUE)
Expand Down