Skip to content

Fix for rtools_path() failing on R for Windows on ARM (R AARCH64) - 3 filepaths accidentally missing a second backslash #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

remlapmot
Copy link
Contributor

@remlapmot remlapmot commented Apr 22, 2025

I noticed on the new GitHub windows-11-arm runner that devtools::check() fails because of what I think is this simple little bug in pkgbuild::rtools_path() - three filepaths are accidentally missing a second backslash.

Without the fix, the error message one sees is:

Error in get(name, envir = cache) : object 'rtools_path' not found
Calls: <Anonymous> -> cache_get -> get
Execution halted

Here you can see a GitHub Actions run with the error:

https://github.com/remlapmot/pkgbuild-test/actions/runs/14597607865/job/40947417646#step:2:4999

Here you can see a GitHub Actions runs complete successfully with this small fix:

https://github.com/remlapmot/pkgbuild-test/actions/runs/14597791955/job/40948043436#step:2:5024

https://github.com/remlapmot/pkgbuild-test/actions/runs/14598013275/job/40948802415#step:2:7900

Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gaborcsardi gaborcsardi merged commit c05bf48 into r-lib:main Apr 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants