Skip to content

feat: Add Config/build/never-clean option to never clean during build #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Apr 27, 2025

Is this something you would support? Happy to add documentation. Do we need a test?

My use cases are duckdb and igraph -- if I need a clean rebuild, I clean, otherwise I'm happy with incremental compiles. The auto-clean gets triggered too frequently, I'm frustrated by it more often than not. The bootstrap.R script doesn't seem to get run with load_all() .

@krlmlr krlmlr requested a review from gaborcsardi April 27, 2025 05:38
@gaborcsardi
Copy link
Member

gaborcsardi commented Apr 27, 2025

Thanks! I am not even sure why needs_clean() is needed, ideally make would handle the dependencies and rebuild only the object files that need rebuilding.

Maybe we could remove needs_clean() entirely?

@gaborcsardi
Copy link
Member

OK, I see now that changing a header file does not trigger recompilation of the objects that use it, so that's why we have needs_clean(). Maybe we can do better with gcc -MM?

I am still not sure why a missing DLL would need a cleanup.

@gaborcsardi
Copy link
Member

In the meanwhile I don't mind adding this flag.

@gaborcsardi gaborcsardi merged commit 937e05a into main Apr 27, 2025
21 checks passed
@krlmlr
Copy link
Member Author

krlmlr commented Apr 27, 2025

Thanks. Added NEWS and docs in e4e5fb8 .

R has a .c|.cpp -> .d rule built in, all we need (in theory) is include file.d for each file.c or file.cpp . In duckdb, I'm doing more:

  • Excluding system and vendored headers
  • Version-controlling the generated files

Let's see.

@krlmlr krlmlr deleted the f-never-clean branch April 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants