Open
Conversation
lionel-
reviewed
Jul 14, 2024
Member
lionel-
left a comment
There was a problem hiding this comment.
I think this should be allow_empty and apply to all vector types?
Could also be something like length = c("any", "non_empty", "scalar")? It seems like this change deserves some discussion about general vector checks.
Contributor
Author
|
I agree. However I like the the proposed |
olivroy
commented
Aug 15, 2024
Contributor
Author
olivroy
left a comment
There was a problem hiding this comment.
Modify the stop_input_type() call for:
what <- "character vector"
if (min_length > 0) {
what <- paste0(what, "of length greater or equal to", min_length)
}allow_zero to check_character()min_length to check_character()
olivroy
commented
Aug 15, 2024
olivroy
commented
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you want something non-empty.
allow_zero = FALSEwill disallowcharacter(0). Addresses #1618 (comment)