Draft
Conversation
lionel-
reviewed
Aug 21, 2024
Member
lionel-
left a comment
lionel-
left a comment
There was a problem hiding this comment.
A few comments but looking good. Also need to add a news bullet at the top of the standalone file.
| } | ||
|
|
||
| if (vector) { | ||
| what <- sprintf("%s vector") |
| ..., | ||
| exit_code = exit_code, | ||
| allow_decimal = TRUE, | ||
| vector = TRUE, |
Member
There was a problem hiding this comment.
Potential upgrade: Should probably pass the indices of the failing elements, as well as the reasons, so they can be reported in the error message. These should be truncated if there are too many.
But in a first pass it's fine to just fail saying all elements in the vector should follow the required invariants.
| expect_null(check_numbers_decimal(c(10, 5.5))) | ||
| expect_null(check_numbers_decimal(c(10L, 50L))) | ||
|
|
||
| expect_snapshot({ |
Member
There was a problem hiding this comment.
It looks like you still need to generate and commit this snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
does this looks like it is going in the right direction? @lionel-