Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for warnings in examples #1219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Check for warnings in examples #1219

wants to merge 2 commits into from

Conversation

IndrajeetPatil
Copy link
Collaborator

@lorenzwalthert We can either do this and/or add a new workflow from lintr that runs tests in strict mode.

I prefer doing both, but wanted to first check with you.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (7b5327c) to head (e19bc2c).

Current head e19bc2c differs from pull request most recent head 27a07d5

Please upload reports for the commit 27a07d5 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files          46       46           
  Lines        2647     2647           
=======================================
  Hits         2424     2424           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzwalthert
Copy link
Collaborator

I also prefer both 👍.

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Jul 1, 2024

Do we really need a separate workflow or can we incorporate it an existing one? I try to limit compute time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants