-
Notifications
You must be signed in to change notification settings - Fork 73
Ensure formatted token is a call before forcing line breaks #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PS it might help to write something about fledge in the CONTRIBUTING guide, I am not sure how to approach ensuring there is a proper NEWS entry. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if c4b7b89 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 46 46
Lines 2656 2658 +2
=======================================
+ Hits 2434 2436 +2
Misses 222 222 ☔ View full report in Codecov by Sentry. |
@MichaelChirico thanks for the contribution. Actually I don't use {fledge} anymore. It did not help me to make my release workflow faster since it failed multiple times when I tried it and the commands were not transparent (enough) to me. Can you please remove the reference to the PR? It's not really the convention in this repo, I mostly use |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e7b1565 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Sorry, is this about {fledge} (which I found at the top of the NEWS when considering an entry), or the comment about the issue # in the test suite? |
Two separate things:
|
tests/testthat/line_breaks_fun_call/switch_ifelse_etc_no_line_break-in.R
Outdated
Show resolved
Hide resolved
tests/testthat/line_breaks_fun_call/switch_ifelse_etc_no_line_break-out.R
Outdated
Show resolved
Hide resolved
OK, done |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0e2cbaf is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Great, thanks @MichaelChirico |
Closes #1253.
Appreciate some guidance on how to sew this up into a complete PR.