Remove optional()
fields where possible
#132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #126, which was getting too complicated
Implementing the idea in #126 was actually going to force our hand on this anyways. The
optional()
s just introduce too much ambiguity into the grammar for what they are worth.Also removed the stack crash test as it was getting too annoying to maintain
Isolating this change shows that it is what results in most of the simplification in the grammar.
Before:
After: