HTTPS support #110
Merged
HTTPS support #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But no HTTP yet, and I need to get rid of `printf()`, `putchar()`, `puts()` and `rand()` calls.
All the printed messages are lost now. I should probably print them if `DEBUG` is set or if `NDEBUG` is not set.
Not 127.0.0.1, apparently.
The cainfo option only works with the openssl backend. Need to run tests in a subprocess, with CURL_SSL_BACKEND=openssl set, because libcurl sets this on load.
Need to set `CURL_CA_BUNDLE` as well, the `cainfo` option does not seem to work on older R versions.
1. they need to run in a subprocess 2. with env vars set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.