S3 chapter #101
S3 chapter #101
Conversation
jonthegeek
left a comment
jonthegeek
left a comment
There was a problem hiding this comment.
I made a bunch of small edits up through the beginning of the constructor function section, but I want to send it back your way to see if you can tweak the rest based on those suggestions. I'm being a little more "strict" in this review than I often am to make sure we nail what I think is a super important topic! I'll have a lot of time tomorrow (Sunday) if you need help with further revisions. I recommend applying my suggestions directly on GitHub, then pull those changes and continue with your own, then finally push back up.
Ugh I wrote this yesterday (Saturday) but evidently didn't click "Submit review"! Sorry!
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Jon Harmon <[email protected]>
|
I may have time tomorrow night for any last changes you think should be made! |
jonthegeek
left a comment
jonthegeek
left a comment
There was a problem hiding this comment.
I can't check as thoroughly as I'd like, but they're certainly better than how they were before the PR, and that's really all we're aiming for... and what I've reviewed thoroughly is beyond that into "really good," so yay!
2 participants
This is the slides for the S3 chapter presentation. After previewing, all the code either fits on a single slide or can be scrolled easily. I'm using the assertion-evidence style as well. I made the PR following closely the README instructions. Let me know if I need to do any more revisions!