Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chapter 8 - Decision trees Quarto main and notes documents, including images and Hitters dataset #7

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Update Chapter 8 - Decision trees Quarto main and notes documents, including images and Hitters dataset #7

merged 4 commits into from
Dec 1, 2023

Conversation

rserran
Copy link
Contributor

@rserran rserran commented Dec 1, 2023

No description provided.

jonthegeek
jonthegeek requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include .vdoc.py and .vdoc.r at the root? Those don't look like they should be there. If not, delete them and push an update to this PR!

It looks great other than those!

jonthegeek
jonthegeek approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonthegeek jonthegeek merged commit 46e1587 into r4ds:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rserran @jonthegeek