-
Notifications
You must be signed in to change notification settings - Fork 10
Chapter 15 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 15 #28
Conversation
lgibson7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Angel. On my end, the iframes don't seem to be loading properly when I knit ch15 or build the book.
Pinging @jonthegeek to get a second pair of eyes. It could just be my machine.
|
Edit: It maybe works? I see that "Add message" is adding to the count in the messages element. But clicking those doesn't work (it fails the way described below when it's an iframe, or opens a mostly empty version of the app when I load the app in its own tab by copy/pasting the URL). When I I assume that's not what's supposed to happen, but I didn't watch the video/read the slides in detail to see if maybe it's a partially complete app or something. |
jonthegeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for me!
Dismissing this one so it can merge smoothly.







No description provided.