Skip to content

Conversation

@AngelFelizR
Copy link
Contributor

No description provided.

Copy link
Member

@lgibson7 lgibson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Angel. On my end, the iframes don't seem to be loading properly when I knit ch15 or build the book.

Pinging @jonthegeek to get a second pair of eyes. It could just be my machine.

@lgibson7 lgibson7 requested a review from jonthegeek May 17, 2025 19:54
@AngelFelizR
Copy link
Contributor Author

Shinylive is working, but you need to open the presentation from browser.

image

@jonthegeek
Copy link
Member

Edit: It maybe works? I see that "Add message" is adding to the count in the messages element. But clicking those doesn't work (it fails the way described below when it's an iframe, or opens a mostly empty version of the app when I load the app in its own tab by copy/pasting the URL).


When I pr_fetch(28), pak::pak() to make sure my packages are up-to-date, ctrl-shift-b to render, and open in browser, the apps load, but they don't seem to work. I see an "Add dropdown item" button, but clicking it doesn't do anything, for example. Or (in the earlier app) I see "Add message", but clicking that doesn't work. When I click a message, I get an error. This is an example (there's a separate one about authentication but I'm not getting that one at the moment):

Couldn't find parent page for https://shinylive.io/r/app/app_xpjy8qc8x7twbqxf214s/#. This may be because the Service Worker has updated. Try reloading the page.

I assume that's not what's supposed to happen, but I didn't watch the video/read the slides in detail to see if maybe it's a partially complete app or something.

@AngelFelizR
Copy link
Contributor Author

I checked all the apps and they are working as expected by adding one element to the list.

01-shinylive-app
02-shinylive-app
03-shinylive-app
04-shinylive-app
05-shinylive-app

Here is the browser I am using

my-sistema

Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me!

@jonthegeek jonthegeek dismissed lgibson7’s stale review May 18, 2025 22:58

Dismissing this one so it can merge smoothly.

@jonthegeek jonthegeek merged commit 3fdb013 into r4ds:main May 18, 2025
1 check passed
@AngelFelizR AngelFelizR deleted the chapter_15 branch July 4, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants