Skip to content

update open_jtalk for #99 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

update open_jtalk for #99 #100

merged 2 commits into from
Apr 8, 2025

Conversation

r9y9
Copy link
Owner

@r9y9 r9y9 commented Mar 31, 2025

includes fixes for cmake 4.0 that drops compatibility with older cmakes that do not specify cmake 3.5 as upper bound in cmake_minimum_version

fixes #99

includes fixes for cmake 4.0 that drops compatibility with older cmakes
that do not specify cmake 3.5 as upper bound in cmake_minimum_version
@r9y9 r9y9 mentioned this pull request Mar 31, 2025
@sabonerune
Copy link
Contributor

I have confirmed that it installs correctly on my Windows computer.


I think you can also modify the following code:

pyopenjtalk/setup.py

Lines 103 to 108 in ae1a729

# NOTE: The wrapped OpenJTalk does not depend on HTS_Engine,
# but since HTSEngine is included in CMake's dependencies, it refers to a dummy path.
r = subprocess.run(
["cmake", "..", "-DHTS_ENGINE_INCLUDE_DIR=.", "-DHTS_ENGINE_LIB=dummy"]
)

-
-    # NOTE: The wrapped OpenJTalk does not depend on HTS_Engine,
-    # but since HTSEngine is included in CMake's dependencies, it refers to a dummy path.
-    r = subprocess.run(
-        ["cmake", "..", "-DHTS_ENGINE_INCLUDE_DIR=.", "-DHTS_ENGINE_LIB=dummy"]
-    )
+    r = subprocess.run(["cmake", ".."])

hts_engine is no longer necessary by default
@r9y9 r9y9 merged commit 92bb01b into master Apr 8, 2025
8 checks passed
@r9y9 r9y9 deleted the fix-cmake4 branch April 8, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.0 Install Issue
2 participants