Fix auto exposure and autofocus not working properly. Issue 341 #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, it really fixes the problem. |
T-Pham
reviewed
Mar 2, 2018
| newDevice.exposureMode = AVCaptureExposureModeContinuousAutoExposure; | ||
| } | ||
| if ([newDevice isFocusModeSupported:AVCaptureFocusModeContinuousAutoFocus]) { | ||
| newDevice.exposureMode = AVCaptureFocusModeContinuousAutoFocus; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that when subject area change is detected, we try to do an autofocus on the centre of the image, then we wait for that focus operation to be done to put the camera back in continuous focus/exposure mode. The problem is that the front cam doesn't support that focus mode and the focus operation never completes. In fact, in
_applyPointOfInterest:continuousMode:,focusingstays asNO. Now, if we cause the camera to get its exposure really high(by covering the lens for example) the image becomes all white, and no further subject area changes occur and we're now stuck in non-continuous mode.The proposed fix is to disable this entire piece of logic if the camera is incapable of doing any kind of autofocus anyway. I've tested this change and it works well and I don't think it breaks anything. If it does, I'll be happy to fix it so it can be merged