feat(penis): mods+ trumps all #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portalBlock
added
enhancement
rippleFCL
requested changes
Mar 3, 2025
| @@ -30,7 +33,7 @@ async def penis(self, ctx, *users: discord.Member): | |||
|
|
|||
| for user in users: | |||
| random.seed(user.id) | |||
| dongs[user] = "8{}D".format("=" * random.randint(0, DONG_DISTRIBUTION_CONST)) | |||
| dongs[user] = "8{}D".format("=" * (random.randint(0, DONG_DISTRIBUTION_CONST), VIP_DONG_CONST)[await is_mod_or_superior(ctx.bot, user)]) | |||
There was a problem hiding this comment.
insted of generating the vip dong everytime. move it into the constant
| @@ -40,6 +43,9 @@ async def penis(self, ctx, *users: discord.Member): | |||
| msg += "**{}'s size:**\n{}\nlol small\n".format(user.display_name, dong) | |||
| elif len(dong) <= BIG_DONG_CONST: | |||
| msg += "**{}'s size:**\n{}\n".format(user.display_name, dong) | |||
| elif len(dong) >= VIP_DONG_CONST: | |||
There was a problem hiding this comment.
if the vip dong is moved into the constant check it with eq here insted. bit more readable
|
also @portalBlock do you have the pre-commit hooks installed? it should catch ci pipeline failes early befor you commit |
|
Should probably also mention this adjustment in the cog docs in the README. |
|
Added SPECIAL_USER_IDS list and logic override for users in SPECIAL_USER_IDS. |
rippleFCL
reviewed
Mar 3, 2025
|
Can we not commit to other people's branches without discussion? That should be a separate PR anyway, IMO. |
sorting_trollface_algorithm.mp4 |
This reverts commit a40fef9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Checklist
Details
Does this resolve an issue?
Resolves #313
Changes
Features / Fixes
Breaking Changes
Additional
None