-
Notifications
You must be signed in to change notification settings - Fork 49
Add support to Asynchronous API #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4.1-dev
Are you sure you want to change the base?
Conversation
Ah, I inputed the original dataset ID into asynchronous function, so of course it would output nonsensical results. Maybe it would be useful to warn the user for this kind of use, see the history of this comment for example output. I will test this more. |
I'm sure you have already read the Eurostat documentation on this but I'll just copy-paste it here
I think when it comes to triggering the asynchronous request and keeping things within the Fair use limits we should refrain from running any automated tests on this functionality.
Maybe 1 of this type of request could be recorded and used as a dummy? I don't immediately have the answer to that Btw, while trying to trigger the asynchronous response I tested get_eurostat_sdmx with the dataset "bop_iip6_q". Curiously, I was able to download the whole dataset with no filters and all 57,312,860 rows. I thought it would've for sure triggered the async response or an error, but no. It was very slow though. |
i used some queries like the one below to trigger async but the thing is you can't use the same query again as it is cached by the server I guess so it changes to synchronous mode and says "Synchronous mode: CSV data returned directly."
|
I'm satisfied if you can get the function working just once. We can mark it with an Experimental tag (or similar) in the man pages |
Add support to Asynchronous API #319