Don't allow a non-voter to start elections #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transfer_leadership is requested, the leader checks whether the desired new leader is a voter and refuses to proceeed if it is not. However, the desired new leader should also refuse to proceed, if it doesn't consider itself a voter (the view of the membership may be different on different nodes or might have changed since the old/current leader checked it). This fixes a behaviour we observed in testing where a newly added member, which was still catching up, was picked to be a new leader and actually became a leader, even though it was still in the `promotable` state.
It duplicates the functionality of election_timeout, so let's just call the election_timeout
mkuratczyk
force-pushed
the
do-not-call-for-elections-if-you-cannot-vote
branch
from
73403df to
215611c
Compare
kjnilsson
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transfer_leadership is requested, the leader checks whether the desired new leader is a voter and refuses to proceed if it is not. However, the desired new leader should also refuse to proceed, if it doesn't consider itself a voter (the view of the membership may be different on different nodes or might have changed since the old/current leader checked it).
This fixes a behaviour we observed in testing where a newly added member, which was still catching up, was picked to be a new leader and actually became a leader, even though it was still in the
promotablestate.