Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates for the current OTel (OpenTelemetry) conventions #1717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iinuwa
Copy link
Contributor

@iinuwa iinuwa commented Oct 31, 2024

Proposed Changes

Update to latest OTel conventions

  • Swap order of queue name and operation name in Activity name
  • Add messaging.operation.name tag

Builds on #1716.
Fixes #1715.

In order to get 7.0 released, this can wait until 7.1.

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Regarding #1715 (comment), I used fetch instead of polling fetch or basic.get because:

  • It avoids using longer basic_ prefix.
  • It remains consistent with a single verb for all operation names.
  • The word "polling" (to me) implies that the operation is repeated multiple times, but this activity is fired on a single instance of the basic.get. fetch (in my mind) conveys a pull operation to me and is meaningfully distinguished from deliver.

@michaelklishin
Copy link
Member

@iinuwa should we close #1716 then? Is this meant to address the feedback there?

@lukebakken lukebakken added this to the 7.1.0 milestone Oct 31, 2024
@lukebakken lukebakken self-assigned this Oct 31, 2024
@michaelklishin michaelklishin changed the title Feat/update otel conventions More updates for the current OTel (OpenTelemetry) conventions Nov 1, 2024
@lukebakken lukebakken self-requested a review November 1, 2024 13:59
- Swap order of queue name and operation in Activity name
- Add messaging.operation.name tag
@iinuwa iinuwa force-pushed the feat/update-otel-conventions branch from de3ae7f to bfaaaf7 Compare November 1, 2024 16:37
@iinuwa
Copy link
Contributor Author

iinuwa commented Nov 1, 2024

@iinuwa should we close #1716 then? Is this meant to address the feedback there?

Sorry, I missed this message. This is a follow-up for after 7.0 is released. Thanks for merging #1716!

@stebet
Copy link
Contributor

stebet commented Nov 1, 2024

Was just catching up all this and the previous PR #1716 and I see @lmolkova addressed most of the things there (thanks!).

Good to see more people picking up OTel and keeping the integration going, thank you @iinuwa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry: Update messaging.operation span attribute to latest OTel Semantic Conventions
4 participants