Automated Resyntax fixes #785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
This conditional expression can be replaced with a simpler, equivalent expression.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
These nested `for` loops can be replaced by a single `for*` loop.
This quasiquotation is equialent to a simple `list` call.
This use of `printf` has no arguments other than the template string.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This named `let` expression is equivalent to a `for` loop that uses `in-range`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 8 files.
provide/contract-to-contract-outmap-to-forprintf-to-displaylist-element-definitions-to-match-defineif-let-to-condquasiquote-to-listnamed-let-loop-to-for-in-rangeunless-expression-in-for-loop-to-unless-keywordwhen-expression-in-for-loop-to-when-keywordlet-to-definecond-void-to-when-or-unlessnested-for-to-for*