fromLinks add missing param to loadSingle call #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Is that possible to Merge this PR from 7 months ago? |
|
Hah, whoops! Am just merging in some other changes which may cause conflicts with this, so I'll do it manually afterwards. Thanks for bumping it |
Rich-Harris
added a commit
that referenced
this pull request
Mar 18, 2015
|
can we close this one then @Rich-Harris? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #7. Not really sure if this is right thing to do, but loading fromLinks doesn't work otherwise (I'm I the only one loading from links? What are all the kool kids using, AMD?)
Also passed along cache parameter in other instance @MartinKolarik mentioned.
Not as familiar with this code, so would appreciate someone chiming in.