Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added abstract DataLoader to enable simple backend implementations #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added abstract DataLoader to enable simple backend implementations #38

wants to merge 1 commit into from

Conversation

ruivieira
Copy link
Member

Data store calls are now handled via the concrete PostgresDataLoader.

Additional backends can be made by implementing the DataLoader abstract class.

@ruivieira ruivieira self-assigned this Apr 12, 2018
@ruivieira
Copy link
Member Author

@elmiko @sophwats ptal.

elmiko
elmiko reviewed Apr 12, 2018
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a nice refactor, i have not tested it though

@sophwats
Copy link

have tested on openshift. lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

Assignees

@ruivieira ruivieira

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruivieira @sophwats @elmiko