Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add howdoi links #223

Merged
merged 5 commits into from
Jul 30, 2018
Merged

Add howdoi links #223

merged 5 commits into from
Jul 30, 2018

Conversation

elmiko
Copy link
Collaborator

@elmiko elmiko commented Jul 27, 2018

this change brings in individual page links for each "how do i" article. it also moves each article to its own page. additionally, the link from the jupyter python package installation article has been updated with a link to the jupyter article.

@elmiko elmiko requested a review from willb July 27, 2018 20:43
@elmiko
Copy link
Collaborator Author

elmiko commented Jul 27, 2018

@willb @ruivieira would love to hear your thoughts

@elmiko
Copy link
Collaborator Author

elmiko commented Jul 27, 2018

this addresses #199 and partially addresses #218

elmiko added 3 commits July 27, 2018 17:41
This change makes it easier to link directly to individual "how do i"
articles by rendering them to their own pages.

changes
* update collection url info
* add a new layout for how do i articles
* update articles with new layout
* change styling on how do i page to use a more minimal list
* add styling for new list and layout
This just adds a direct link to the jupyter notebook how do i article.
@elmiko elmiko force-pushed the add-howdoi-links branch from ece8648 to 7488266 Compare July 27, 2018 21:41
@ruivieira
Copy link
Member

@elmiko lgtm!

Just a microscopic aesthetic note (feel free to ignore): "How do I ... ?" page header is <h1> and each article's header is <h2> (https://github.com/radanalyticsio/radanalyticsio.github.io/pull/223/files#diff-142f6c69a10a1f26d0e190369611be76R8). If both are the same, I find it more pleasing to the eye.

@elmiko
Copy link
Collaborator Author

elmiko commented Jul 30, 2018

good suggestion @ruivieira , i changed the titles in the template. thanks!

@ruivieira
Copy link
Member

@elmiko lgtm!

@elmiko elmiko merged commit 13ea1d3 into radanalyticsio:master Jul 30, 2018
@elmiko elmiko deleted the add-howdoi-links branch July 30, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants