Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data set creation routine #53

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Update data set creation routine #53

wants to merge 37 commits into from

Conversation

aknierim
Copy link
Member

@aknierim aknierim commented Jan 29, 2025

Maintenance

  • Add a complete rewrite of dataset creation routine pyvisgen.simulation.data_set.SimulateDataSet
    • Accessible using a classmethod to load a config file
    • Add optional multithreading support
    • Draw and fully test parameters before simulation loop. Previously this was done in the loop and tests were only performed for two time steps
    • Support for polarization
  • Add new default config file for new dataset creation routine
  • Update CLI tool for dataset creation routine
  • Allow passing HDF5 key in pyvisgen.utils.data.open_bundles
  • Restructure pyvisgen.gridding module by adding a utils submodule that contains all utility functions that previously were in the gridder submodule
    • Also fix parts of the utility functions
  • Update and fix tests

New Features

  • Add new gridder that can handle vis data returned by the vis_loop

@aknierim aknierim added the enhancement New feature or request label Feb 2, 2025
@aknierim aknierim marked this pull request as ready for review February 28, 2025 15:10
@aknierim aknierim requested a review from Kevin2 February 28, 2025 18:18
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 82.19178% with 78 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (c1169d1) to head (b9106e9).

Files with missing lines Patch % Lines
pyvisgen/gridding/utils.py 44.33% 59 Missing ⚠️
pyvisgen/simulation/data_set.py 92.99% 11 Missing ⚠️
pyvisgen/gridding/gridder.py 83.33% 6 Missing ⚠️
pyvisgen/simulation/scan.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   90.40%   81.08%   -9.32%     
==========================================
  Files          19       23       +4     
  Lines        1219     1602     +383     
==========================================
+ Hits         1102     1299     +197     
- Misses        117      303     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aknierim
Copy link
Member Author

Okay, this apparently opened a box of pandora coverage-wise :D

@aknierim aknierim self-assigned this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant