Use actor_types *actor_def
naming everywhere
#218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I was reading through the actor code and found it difficult at times to distinguish between actor entities (the instances operating within the game world) and actor defs (the declarative actor data read from xml on initialization).
Particularly in
actor_scripts.c
, there are many functions that haveactor_types *act
in the signature, and then others in the same file that haveactor *act
. I also found one case inactor_init.cpp
where there is bothactor_types *a, actor *act
in the signature.I think it'd be nice for readability to make it explicitly clear when you're dealing with an actor def instead of an actor entity. So I renamed all
actor_types *act
toactor_types *actor_def
. Hope you agree.