Skip to content

Use actor_types *actor_def naming everywhere #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukehorvat
Copy link
Contributor

Hey, I was reading through the actor code and found it difficult at times to distinguish between actor entities (the instances operating within the game world) and actor defs (the declarative actor data read from xml on initialization).

Particularly in actor_scripts.c, there are many functions that have actor_types *act in the signature, and then others in the same file that have actor *act. I also found one case in actor_init.cpp where there is both actor_types *a, actor *act in the signature.

I think it'd be nice for readability to make it explicitly clear when you're dealing with an actor def instead of an actor entity. So I renamed all actor_types *act to actor_types *actor_def. Hope you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant