Skip to content

feat(rust): escape parameter in format like macros #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ValdezFOmar
Copy link
Contributor

Follow up #486

This was the change suggested by @dev-ardi

@oriongonza
Copy link
Contributor

oriongonza commented Sep 23, 2024

I think that this only makes sense for dbg!, format! and format_args!, where you always want to pass in an argument, for the rest you might be fine without it: println!("hello world").
The rest I don't even think that they should exist as snippets as they don't really add any value over the r-a suggestion.
format_args! is never used outside of macros so I'd vote to kill it as well.

Thoughts?

@oriongonza
Copy link
Contributor

#495

@ValdezFOmar
Copy link
Contributor Author

I think that this only makes sense for dbg!, format! and format_args!, where you always want to pass in an argument, for the rest you might be fine without it: println!("hello world").

Thoughts?

Hmmm, I'm thinking that it might not even be worth it to include this format macros since you probably would like to include more than just the argument (like format specifiers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants