fix set

rafaqz · Oct 14, 2023 · fab1adc · fab1adc
1 parent 47a5609
commit fab1adc
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/BaseInterfaces/src/BaseInterfaces.jl b/BaseInterfaces/src/BaseInterfaces.jl
@@ -10,13 +10,13 @@ include("set.jl")
 include("array.jl")
 
 # Some example interface delarations.
-@implements IterationInterface{(:reverse,:indexing,)} UnitRange
-@implements IterationInterface{(:reverse,:indexing,)} StepRange
-@implements IterationInterface{(:reverse,:indexing,)} Array
-@implements IterationInterface{(:reverse,)} Base.Generator
-@implements IterationInterface{(:reverse,:indexing,)} Tuple
-
-@implements SetInterface Set
+@implements ArrayInterface Base.LogicalIndex # No getindex
+@implements ArrayInterface{(:getindex,)} UnitRange
+@implements ArrayInterface{(:getindex,)} StepRange
+@implements ArrayInterface{(:getindex,:setindex,)} Array
+@implements ArrayInterface{(:getindex,:setindex,)} SubArray
+@implements ArrayInterface{(:getindex,:setindex,)} PermutedDimsArray
+@implements ArrayInterface{(:getindex,:setindex,)} Base.ReshapedArray
 
 @implements DictInterface{(:setindex,)} Dict
 @implements DictInterface{(:setindex,)} IdDict
@@ -26,13 +26,13 @@ include("array.jl")
 @implements DictInterface Base.ImmutableDict
 @implements DictInterface Base.Pairs
 
-# Some example interface delarations.
-@implements ArrayInterface Base.LogicalIndex # No getindex
-@implements ArrayInterface{(:getindex,)} UnitRange
-@implements ArrayInterface{(:getindex,)} StepRange
-@implements ArrayInterface{(:getindex,:setindex,)} Array
-@implements ArrayInterface{(:getindex,:setindex,)} SubArray
-@implements ArrayInterface{(:getindex,:setindex,)} PermutedDimsArray
-@implements ArrayInterface{(:getindex,:setindex,)} Base.ReshapedArray
+@implements IterationInterface{(:reverse,:indexing,)} UnitRange
+@implements IterationInterface{(:reverse,:indexing,)} StepRange
+@implements IterationInterface{(:reverse,:indexing,)} Array
+@implements IterationInterface{(:reverse,)} Base.Generator
+@implements IterationInterface{(:reverse,:indexing,)} Tuple
+
+@implements SetInterface Set
+@implements SetInterface BitSet
 
 end
diff --git a/BaseInterfaces/src/set.jl b/BaseInterfaces/src/set.jl
@@ -3,6 +3,7 @@
 # Requirements for AbstractSet subtypes:
 
 mandatory = (
+    type = s -> s isa AbstractSet,
     eltype = "elements eltype of set `s` are subtypes of `eltype(s)`" => s -> typeof(first(iterate(s))) <: eltype(s),
     length = "set defines length and test object has length larger than zero" => s -> length(s) isa Int && length(s) > 0,
     iteration = "follows the IterationInterface" => x -> Interfaces.test(IterationInterface, x),

diff --git a/BaseInterfaces/test/runtests.jl b/BaseInterfaces/test/runtests.jl
@@ -25,4 +25,5 @@ end
 
 @testset "SetInterface" begin
     @test Interfaces.test(SetInterface, Set, [Set((1, 2))])
+    @test Interfaces.test(SetInterface, BitSet, [BitSet((1, 2))])
 end