Skip to content

Commit

Permalink
Remove approval block to run tests, lint, and annotations
Browse files Browse the repository at this point in the history
These steps are designed so any code executed from the workspace happens
inside an unprivileged docker container.

We would get faster feedback on PRs if these run instantly.
  • Loading branch information
zzak committed Dec 2, 2024
1 parent 13b395c commit bd7fd1a
Showing 1 changed file with 28 additions and 14 deletions.
42 changes: 28 additions & 14 deletions pipelines/buildkite-config/initial.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@
# This config is intended for running the rails/buildkite-config CI.

steps:
- block: "Review Build Script"
branches: "!main"
prompt: |
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- group:
label: ":pipeline: buildkite-config meta-ci"
key: "meta"
Expand Down Expand Up @@ -92,7 +82,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI pipeline for the main branch with this config?
We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- trigger: "rails-ci"
label: ":pipeline: Build Rails main with new config"
depends_on: block-rails-ci-main
Expand All @@ -108,7 +104,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI pipeline for the stable branch with this config?
We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- trigger: "rails-ci"
label: ":pipeline: Build Rails 6-1-stable with new config"
depends_on: block-rails-ci-stable
Expand All @@ -124,7 +126,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the main branch with this config?
We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- trigger: "rails-ci-nightly"
label: ":pipeline: Build Rails main with new nightly config"
depends_on: block-rails-ci-nightly-main
Expand All @@ -140,7 +148,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the stable branch with this config?
We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- trigger: "rails-ci-nightly"
label: ":pipeline: Build Rails 6-1-stable with new nightly config"
depends_on: block-rails-ci-nightly-stable
Expand Down

0 comments on commit bd7fd1a

Please sign in to comment.