add unicode string support #138
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should at least resolve the issue seen in rails#77. I created a 'bad' PDF containing 'wmv' (see `strings test/fixtures/name/application/pdf/wmv.pdf | rg wmv2`). And with `unicodeBE` and `unicodeLe` support, `wmv` and `wma` files aren't mistakenly identified as `video/x-ms-asf` (it's not wrong since they're using ASF but it's not the quite specific type). Furthermore it also resolves the `audio2.mp3` case of issue rails#125
alexanderadam
force-pushed
the
feat/add_unicode_string_type_support
branch
from
8c94785 to
2b19be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi folks,
this should at least solve the PDF issue seen in issue 77 (third comment).
I created a 'bad' PDF containing
wmv(seestrings test/fixtures/name/application/pdf/wmv.pdf | rg wmv2).And with
unicodeBEandunicodeLesupport,wmvandwmafiles aren't mistakenly identified asvideo/x-ms-asf(it's not wrong since they're using ASF but it's not the quite specific type).However, keep in mind that I while I attached some fixtures, I didn't includea valid
zipfile containingwmv2(see the first comment in the issue).I'd assume that this is also solved by this PR but I don't know how to properly reproduce a valid zip file containing the string without brute forcing tbh. 🔨
Furthermore it also resolves the
audio2.mp3case of issue #125PS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev