Supress sqlite fork warnings for rails 7.1 & 7.2#611
Conversation
|
Actually, the warning is still showing up in the CI - wait a sec. |
90cf406 to
c5f43a0
Compare
|
Done! No more warnings in the CI as well: https://github.com/rails/solid_queue/actions/runs/16473942583/job/46570298080?pr=611 |
|
Hey @p-schlickmann, thanks a lot for this! I think I'd keep only the call for tests only, in |
|
Yes, @rosa, that approach should work! But in addition to cleaning up the CI logs, the goal of this PR is to reassure Solid Queue users on Rails 7.1 and 7.2 that the forking warning is harmless and can be safely ignored. Maybe it makes sense to open a PR against the Rails repo to suppress this warning upstream in Rails 7 itself? Like they did for Rails 8? |
|
Maybe, yes, I'd prefer that if the core team allows it. |
c5f43a0 to
9853aca
Compare
|
@rosa, unfortunately we can’t apply the same fix in Rails 7 because I don't think a warning is gonna make the rails team bump such a major version like that. In any case, I’ve pushed a commit to suppress those warnings in our CI, so our test output is now completely clean 🎉 |
When sqlite3 > 2.1.0 and rails < 8.0.0 we have the following warning when using Solid Queue:
This is polluting our CI logs and triggering warnings for people using Solid Queue with Rails 7.1 and 7.2 - although the behaviour is safe: #324 (comment)
Also mentioned in: #506