Decouple config.asset_host
assignment from rails:
#415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple
config.asset_host
assignment from rails:config.action_controller.asset_host=
andconfig.asset_host=
(the latter being usefull to both set action_mailer/action_controller asset_host)config.action_controller
currently works when the asset_host is defined usingconfig.asset_host
but I feel like this might be by chance:action_controller.set_configs
initializer runs. A variableoptions
is assigned and referenceconfig.action_controller
. Theoptions
variable get modified and by doing so modify the refernce toconfig.action_controller
https://github.com/rails/rails/blob/1bee2fb600c07625b830afd33b43ead3364c9715/actionpack/lib/action_controller/railtie.rb#L50.div { background-image: url('/assets/rails.png') }
) will not be prefixed by the asset_host