Handline Inline Sourcemaps #522
Open
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklozon
commented
Feb 21, 2024
| @@ -2,21 +2,25 @@ module Sprockets | |||
| module Rails | |||
| # Rewrites source mapping urls with the digested paths and protect against semicolon appending with a dummy comment line | |||
| class SourcemappingUrlProcessor | |||
| REGEX = /\/\/# sourceMappingURL=(.*\.map)/ | |||
| FILE_REGEX = /\/\/# sourceMappingURL=(.*\.map)/ | |||
| INLINE_REGEX = /\/\/# sourceMappingURL=(data:.*)$/ | |||
There was a problem hiding this comment.
Typically inline sourcemaps will look something like this: sourceMappingURL=data:application/json;base64,abc123= where abc123= is encoded data. The regex assumes anything starting with data: is an inline sourcemap, which I fell is a safe assumption from my experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sprockets gem appends semicolons to each js asset which corrupts
//# sourceMappingURL=magic comments.sprockets-railsfixes this by appending\n//!\nto the asset so thesourceMappingURLis not the last line and in turn not corrupted by the semicolon. This only applies to external sourcemap files.This PR improves
SourcemappingUrlProcessorto also add\n//!\naftersourceMappingURLcomments when they contain inline sourcemaps.