Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve partial: correct use of tags + attachment links styling #460

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

patriciomacadden
Copy link
Contributor

The partial used <p> elements for each attribute, which auto-close if it contains a <div> element (see the technical summary of the p tag). To avoid this, I'm changing the p elements to div elements.

Also, adding some basic styling for the attachment links.

See before and after screenshots:

before after comment
image image the space between "Documents" and the links changed due to the correct use of tags, and the links now are styled differently (similar to "forgot your password?" link
image image the p element auto-closed due to the inner div, by changing it to a div we produce a better output

@flavorjones
Copy link
Member

Because tailwind v4 just shipped, I'm going to hold off until this gem properly supports it, then we can make sure this PR is styled appropriately for v4.

@flavorjones
Copy link
Member

Love it. Thank you!

@flavorjones flavorjones merged commit 1f68bbb into rails:main Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants