fix: better elixir docs and defaults #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder regarding this pull request! Please let me know if there are any further updates needed. |
coffee-cup
added
release/patch
coffee-cup
reviewed
Nov 8, 2024
| @@ -51,9 +45,6 @@ impl Provider for ElixirProvider { | |||
| build_phase.add_cmd("mix assets.deploy".to_string()); | |||
| } | |||
|
|
|||
| if mix_exs_content.contains("postgrex") && mix_exs_content.contains("ecto") { | |||
| build_phase.add_cmd("mix ecto.setup"); | |||
There was a problem hiding this comment.
Ah, for me I didn't want this. Will add it back in.
The risk with running ecto.setup is it generally requires a DB connection, which is not available when the image is being built.
There was a problem hiding this comment.
Oh yeah thats no worries then. I'll merge as is but I wonder if we can detect if ecto setup is needed/will work
coffee-cup
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main improvements:
I don't think additional tests are needed here. Refactored to pattern off of the python provider a bit more closely.