Skip to content

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Sep 10, 2025

Fixes BX-1855

Summary

  • ensure send amount is captured and compared against Activity list
  • define send flow input amount as constant

Testing

  • CI=1 yarn lint
  • CI=1 yarn typecheck
  • CI=1 yarn vitest:send (fails: Could not validate chrome version. Binary may not be installed)

https://chatgpt.com/codex/tasks/task_e_68c058ed406c8325af6ac36ceb0e1de2


PR-Codex overview

This PR focuses on improving the transaction handling and UI display in the application, particularly in the transaction title resolution and the send flow tests.

Detailed summary

  • In src/core/utils/transactions.ts, changed the title resolution to always use 'pending'.
  • In src/entries/popup/pages/home/Activity/ActivitiesList.tsx, introduced resolvedTitle for displaying the activity title.
  • Updated the send flow test to include setting an amount and verifying it.
  • Enhanced tests to check for pending and sent transaction states in the Activity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@DanielSinclair DanielSinclair marked this pull request as draft September 11, 2025 04:09
Copy link

linear bot commented Sep 11, 2025

@DanielSinclair DanielSinclair force-pushed the codex/add-e2e-coverage-for-eth-send-flow branch from 7d0d692 to ade8d9a Compare October 14, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant