Skip to content

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Sep 24, 2025

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test


PR-Codex overview

This PR primarily focuses on updating the test files to replace the driver.quit() calls with a new cleanupDriver(driver) function, which handles driver cleanup more effectively. Additionally, it introduces several JSON mock files with updated slippagePercent values.

Detailed summary

  • Replaced driver.quit() with await cleanupDriver(driver) in multiple test files.
  • Added new JSON mock files with a slippagePercent of 2 for various swap scenarios.
  • Enhanced cleanupDriver function to manage BiDi interceptor cleanup before quitting the driver.
  • Introduced BiDiManager class for better management of BiDi lifecycle in tests.

The following files were skipped due to too many changes: e2e/mocks/swap/quote/47340cf37ec568d85c017c8c9cacfb330a6aefd1515158e75066ad213bf7cc1f.json, e2e/mocks/addys/assets/5ec33e799d8768a9b23f4613a0b419a70286f9ce944a5f848204f3bfbd059d5a.json, e2e/mocks/swap/quote/d37cfab3f9456439dc8c0cdfee67eb993e67ac7b14ddd6be49a961d1955c28c1.json, e2e/mocks/addys/assets/3360131b929c579e03088a6e04eb1707f06aa5b4ad0cb272502e9d5bda7f0f56.json, e2e/mocks/swap/quote/9a0f9a2a14982214eb247a285bb83ca5028efba339509b4fe942f7189e0afb3c.json, e2e/mocks/swap/quote/379416b0e8e9f9e36b45eec57b1978238f5af1496206e9a8ce28dddfe3945ed7.json, e2e/mocks/swap/quote/00eee74c6fa73c08ecaccb23d69352a4ecfb03c0fc7e2258ace1d63b0264abc2.json, e2e/mocks/swap/quote/741198ed8cce7db26e5189437e915752765779b3800aa8b4492c5895f34e7204.json, e2e/mocks/swap/quote/66297c56338a4369baea388ffc78f69380944266107ebf957b7b65eb98fe036a.json

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant