Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chain modal v2 #1806

Closed
wants to merge 10 commits into from
Closed

feat: chain modal v2 #1806

wants to merge 10 commits into from

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 26, 2024

Changes

  • Now you can choose any chains even if your wallet is not connected.
  • Works with siwe.
  • During connection process, it automatically selects the chain you picked earlier. Or the one you set as your default initialChain instead.
  • If you've set initialChain, the option to change networks will be hidden to prevent accidental switches.
  • The current chain will show up only even if you have one chain unless you set chainStatus to none

Screen recordings / screenshots

chain-modal-v2.mov

What to test

  1. Checkbox the chainModalOnConnect in the example app
  2. Try opening the chain modal and switch through your desired chain
  3. While connecting your wallet, confirm it connects to the chain you chose.
  4. Set initialChain and check if the chain button is no longer visible.
  5. Make sure everything works well with siwe. Test this connecting to your wallet first and then you should see chain button dissapear. This prevents users from switching chains with their connected wallet when they are not signed in yet.

@magiziz magiziz requested a review from a team as a code owner February 26, 2024 11:37
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:54am
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:54am

Co-authored-by: Lukas Lücke <[email protected]>
@oxSaturn
Copy link

oxSaturn commented Apr 1, 2024

Hi, can we expect this feature soon? Been waiting for this a while.

@magiziz
Copy link
Contributor Author

magiziz commented Apr 1, 2024

@0xartcro Apologies for this taking a while, we'll try to aim launching this as soon as possible. Please bear with us 🙏

@magiziz magiziz changed the title feat: chain modal (v2) feat: chain modal v2 Apr 8, 2024
@t0rbik
Copy link

t0rbik commented May 10, 2024

Hey guys! Do you have any progress on this?

@rakpawel
Copy link

Hello! That would be super useful to have :)

@magiziz
Copy link
Contributor Author

magiziz commented May 16, 2024

@rakpawel @t0rbik Apologies for taking a bit long on this. We're deprioritizing this at the moment, but i'll let you guys know when it's merged 👍

@Alexangelj
Copy link

+1 to getting this in

@magiziz
Copy link
Contributor Author

magiziz commented May 29, 2024

@Alexangelj We're aiming to get this in very soon.

@magiziz magiziz linked an issue May 31, 2024 that may be closed by this pull request
1 task
@rakpawel
Copy link

@Alexangelj We're aiming to get this in very soon.

awesome, waiting with update to get it in :)

@magiziz
Copy link
Contributor Author

magiziz commented Jul 15, 2024

@rakpawel We'll have this PR on hold for now, since there might be some new EIP's introduced.

@DanielSinclair DanielSinclair marked this pull request as draft August 22, 2024 05:37
@encryptedDegen
Copy link

Any update on this? Our app would greatly benefit from that functionality.

@akshatmittal
Copy link

Hey @DanielSinclair, why was this closed? Have been looking forward to this one for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants