fix: avoid creating a new WC connector on page reload (when already connected) #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agualis is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
agualis
commented
Feb 20, 2025
| const storageKey = 'rk-WalletConnect-connected'; | ||
|
|
||
| function isLocalStorageAvailable() { | ||
| return typeof localStorage !== 'undefined'; |
There was a problem hiding this comment.
This check is needed to avoid problems when running this check in the RSC pass.
1 task
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2232
Uses localStorage to know if there is an existing Wallet Connect connection after reloading the page.
If yes, it avoids creating a new Wallet Connect connector (
{ ...config, showQrModal: false }) which was leading to broken connection (withError: No matching key. history: <number> error.).The bug could be reproduced in the linked issue or in the the default rainbowkit example (Running
pnpm run devand following the reproduction steps in the linked issue).