Skip to content

Conversation

@louise-davies
Copy link
Member

@louise-davies louise-davies commented Oct 27, 2025

Description

Adds ability to add non-doi related identifiers. Also, adds related identifiers to the landing page and correctly filters out/handles "part" relations (as these are used by the DOI for session DOIs).

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #{issue number}

@louise-davies louise-davies marked this pull request as ready for review November 4, 2025 12:21
@louise-davies louise-davies marked this pull request as draft November 4, 2025 13:46
@louise-davies
Copy link
Member Author

louise-davies commented Nov 4, 2025

Need to wait as the e2e tests are failing due to it not adding the part relations - this is because the old docker image tag doesn't have that code, but we can't use the main tag as that needs the draft/publish PR to merge in to be able to use. So merge the other PR first and test this code with the up to date API

The tests I wrote were passing against the main branch of the API before the draft/publish code though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants