-
Notifications
You must be signed in to change notification settings - Fork 4
Add DataCite metadata confirmation page #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
louise-davies
wants to merge
13
commits into
develop
Choose a base branch
from
feature/metadata-confirm-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aCite metadata from draft endpoint
… confirmation page
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1817 +/- ##
===========================================
+ Coverage 96.60% 96.67% +0.06%
===========================================
Files 214 215 +1
Lines 28826 29510 +684
Branches 4327 4408 +81
===========================================
+ Hits 27848 28529 +681
- Misses 975 978 +3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a confirmation page which displays to the user the data that will be sent off to DataCite. This works with the updated draft/publish workflow in the API instead of the old mint endpoint.
Note: I wanted to use the loading button so added in @mui/lab where necessary, and to ensure I got a compatible version I bumped everything to latest v5. This then causes some changes, mainly to the accessibility of
Selectcomponents and also snapshot changesTesting instructions
Add a set up instructions describing how the reviewer should test the code
/doi-minter) and you should test that you can create new data publications and it shows a confirmation page, and you can edit an existing data publication and see the confirmation page.