Skip to content

Conversation

@louise-davies
Copy link
Member

@louise-davies louise-davies commented Nov 3, 2025

Description

Add a confirmation page which displays to the user the data that will be sent off to DataCite. This works with the updated draft/publish workflow in the API instead of the old mint endpoint.

Note: I wanted to use the loading button so added in @mui/lab where necessary, and to ensure I got a compatible version I bumped everything to latest v5. This then causes some changes, mainly to the accessibility of Select components and also snapshot changes

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • The updated API has been deployed on the dev machine (at /doi-minter) and you should test that you can create new data publications and it shows a confirmation page, and you can edit an existing data publication and see the confirmation page.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 99.35414% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.67%. Comparing base (aeeaad9) to head (b614740).

Files with missing lines Patch % Lines
packages/datagateway-common/src/api/dois.tsx 95.86% 5 Missing ⚠️
packages/datagateway-common/src/main.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1817      +/-   ##
===========================================
+ Coverage    96.60%   96.67%   +0.06%     
===========================================
  Files          214      215       +1     
  Lines        28826    29510     +684     
  Branches      4327     4408      +81     
===========================================
+ Hits         27848    28529     +681     
- Misses         975      978       +3     
  Partials         3        3              
Flag Coverage Δ
common 95.34% <98.97%> (+0.22%) ⬆️
dataview 98.52% <100.00%> (+<0.01%) ⬆️
download 96.91% <100.00%> (+0.08%) ⬆️
search 95.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants