Implement authorisation logic for item rules #551 #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## implement-authorisation-logic-for-usage-statuses-#550 #607 +/- ##
======================================================================================
Coverage 90.36% 90.36%
======================================================================================
Files 58 58
Lines 2139 2139
======================================================================================
Hits 1933 1933
Misses 206 206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements authorisation logic in the
JWTBearerclass, which is then utilised in the itemPATCHendpoint to verify if the user is authorised to then bypass moving item rule checks, and/or allowed to update the usage status.The configuration and setup of the new authorisation logic is in #602, which this PR is based on.
Note
This PR is dependent on this pull request in ldap-jwt-auth, and should be merged in conjunction with it, to avoid breaking changes.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
connect to #551