Skip to content

Conversation

MatteoGuarnaccia5
Copy link
Contributor

Description

This PR implements logic in the unit DELETE and POST endpoints to verify if the user is authorised to perform said operation.
It uses the new JWTBearer functionality from #602

Note
This PR is dependent on ral-facilities/ldap-jwt-auth#271 in ldap-jwt-auth, and should be merged in conjunction with it, to avoid breaking changes.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

connect to #609

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (186167f) to head (b0c3729).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           implement-authorisation-logic-for-rules-#551     #610   +/-   ##
=============================================================================
  Coverage                                         90.36%   90.36%           
=============================================================================
  Files                                                58       58           
  Lines                                              2139     2139           
=============================================================================
  Hits                                               1933     1933           
  Misses                                              206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant