Skip to content

Conversation

joelvdavies
Copy link
Contributor

@joelvdavies joelvdavies commented Oct 14, 2025

Description

See #628. It seems JSONResponse doesn really allow for returning None with a 204 (fastapi/fastapi#4939 (comment)), so switching to use a standard response instead.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes #628

@joelvdavies joelvdavies self-assigned this Oct 14, 2025
@joelvdavies joelvdavies added the bug Something isn't working label Oct 14, 2025
@joelvdavies joelvdavies requested a review from VKTB October 14, 2025 09:28
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.32%. Comparing base (59b88ea) to head (8a0333c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #629   +/-   ##
========================================
  Coverage    97.32%   97.32%           
========================================
  Files           57       57           
  Lines         1983     1983           
========================================
  Hits          1930     1930           
  Misses          53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelvdavies joelvdavies marked this pull request as ready for review October 14, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeError when getting a non existent spares definition

2 participants